Fix next, prev link href #164
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
bitner
approved these changes
Oct 24, 2024
stac_fastapi/pgstac/models/links.py
Outdated
| method = self.request.method | ||
| if method == "GET": | ||
| href = merge_params(self.url, {"token": f"next:{self.next}"}) | ||
| url = self.resolve(f"collections/{self.collection_id}/items") |
There was a problem hiding this comment.
😬 it seems that PagingLinks class is not only used in the /items endpoint but also in the all_collections method
There was a problem hiding this comment.
oh I missed that. I guess that change is not going to work then
|
@smohiudd thanks for the PR First we should add a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When path prefixes are used in FastAPI, the
nextandprevcollection items links don't include the path prefix. See NASA-IMPACT/veda-backend#444 for a specific example. This PR usesself.resolvesimilar to other links (which include the path prefix).